Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scatterplot/ Add basic chart with points #831

Merged
merged 16 commits into from
Feb 14, 2022
Merged

Scatterplot/ Add basic chart with points #831

merged 16 commits into from
Feb 14, 2022

Conversation

kzadurska
Copy link
Collaborator

@kzadurska kzadurska commented Feb 11, 2022 •
edited
Loading

Zrzut ekranu 2022-02-11 o 11 06 05

@kzadurska kzadurska self-assigned this Feb 11, 2022
@kzadurska kzadurska marked this pull request as ready for review February 14, 2022 09:00
@kzadurska kzadurska added the enhancement New feature label Feb 14, 2022
adrianmroz-allegro
adrianmroz-allegro suggested changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@adrianmroz-allegro adrianmroz-allegro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix selectValue comment.

src/client/visualizations/scatterplot/point.tsx Outdated Show resolved Hide resolved
src/client/visualizations/scatterplot/y-axis.tsx Outdated Show resolved Hide resolved
@kzadurska kzadurska merged commit 1ee0104 into feature/scatterplot Feb 14, 2022
@kzadurska kzadurska deleted the scatterplot/basic-chart branch February 14, 2022 11:51
adrianmroz-allegro pushed a commit that referenced this pull request Feb 18, 2022
@kzadurska @adrianmroz-allegro
Scatterplot/ Add basic chart with points (#831)
13ffe98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianmroz-allegro adrianmroz-allegro adrianmroz-allegro approved these changes

Assignees

@kzadurska kzadurska

Labels
enhancement New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kzadurska @adrianmroz-allegro